brkmax/offthrotregen negative or positive?

Introduction and miscellaneous that we haven't created categories for, yet
Post Reply
User avatar
mane2
Posts: 239
Joined: Fri Jan 13, 2023 6:32 am
Location: Finland
Has thanked: 38 times
Been thanked: 35 times

brkmax/offthrotregen negative or positive?

Post by mane2 »

In Wiki, it says brkmax / offthrotregen value is positive 0-100%, but almost all parameters I've seen (including the one I use) it's negative. Also reading the code, I think it needs to be negative. (max -100%)

Is there a reason why it's positive number in Parameters page (https://openinverter.org/wiki/Parameters) or, is my and many others parameter values just plain incorrect? :)
User avatar
mane2
Posts: 239
Joined: Fri Jan 13, 2023 6:32 am
Location: Finland
Has thanked: 38 times
Been thanked: 35 times

Re: brkmax/offthrotregen negative or positive?

Post by mane2 »

To add confusion, in source code test/test_throttle.cpp has:

Throttle::brkmax = 50;

But then again, I think test source code is outdated.

I'm quite sure the value needs to be negative, but would like to get confirmation on this. Then Wiki parameters page could be updated.
User avatar
johu
Site Admin
Posts: 6618
Joined: Thu Nov 08, 2018 10:52 pm
Location: Kassel/Germany
Has thanked: 342 times
Been thanked: 1484 times
Contact:

Re: brkmax/offthrotregen negative or positive?

Post by johu »

Oops, yes please update!
Thanks for checking.
Support R/D and forum on Patreon: https://patreon.com/openinverter - Subscribe on odysee: https://odysee.com/@openinverter:9
User avatar
mane2
Posts: 239
Joined: Fri Jan 13, 2023 6:32 am
Location: Finland
Has thanked: 38 times
Been thanked: 35 times

Re: brkmax/offthrotregen negative or positive?

Post by mane2 »

Thanks for confirming. Updated! https://openinverter.org/wiki/Parameters
Post Reply