Page 1 of 1

Parameter database doesn't browse well

Posted: Sun Jul 31, 2022 6:20 pm
by catphish
I'm not sure if this is my browser (Linux Firefox), but the parameter database is quite broken for me.

1) The pagination doesn't seem to work properly. I only ever see one page.
2) I uploaded a parameter set for Tesla SDU, but when filtering by Tesla SDU, only the default parameter set shows up.
3) Some entries in the list seem to only have a star rating and no other data shown.

Is it just me, or is this broken? In any case, I'm happy to help debug it.

Re: Parameter database doesn't browse well

Posted: Sun Jul 31, 2022 6:55 pm
by johu
It works for me but I also see the entry with only stars. Weird.

Source code is here: https://github.com/jsphuebner/parameter-database

I can attach an SQL dump later if you want to work on it on your local machine. Right now it is a bit too much javascript for my taste, most content could be server generated with php.

Re: Parameter database doesn't browse well

Posted: Sun Jul 31, 2022 7:15 pm
by catphish
johu wrote: Sun Jul 31, 2022 6:55 pm It works for me but I also see the entry with only stars. Weird.

Source code is here: https://github.com/jsphuebner/parameter-database

I can attach an SQL dump later if you want to work on it on your local machine. Right now it is a bit too much javascript for my taste, most content could be server generated with php.
Thanks, if you could post the SQL dump I'll see what I can improve :)

Re: Parameter database doesn't browse well

Posted: Mon Aug 01, 2022 5:53 pm
by catphish
At a glance I believe I can see why the pagination doesn't work well, and why some entries are showing with missing data. This is largely caused by the code assuming that each entry has 10 fields, when in fact they have 11. I'll write some fixes but it would be very useful to have the SQL dump.

Re: Parameter database doesn't browse well

Posted: Fri Aug 05, 2022 11:12 am
by johu
Here you go

Re: Parameter database doesn't browse well

Posted: Fri Aug 05, 2022 11:25 pm
by catphish
johu wrote: Fri Aug 05, 2022 11:12 amHere you go
Thanks, I'll see what I can do. Somebody else reported that they can't successfully browse it and find parameters, so hopefully I can fix it.

Web development was my dayjob until recently. Not usually PHP, but I'm sure I can work it out :)

Re: Parameter database doesn't browse well

Posted: Tue Aug 01, 2023 6:53 pm
by johu
I have replaced the parameter set listing with the old server-side script. That is a bit less functional but it works. Please check it out.

https://openinverter.org/parameters/

EDIT: now submission needs a workover. Right now existing parameters are not updated. So if e.g. an enum is extended that won't be reflected in the database. Also I think deleted parameters don't go away.

Re: Parameter database doesn't browse well

Posted: Wed Aug 02, 2023 8:29 am
by catphish
johu wrote: Tue Aug 01, 2023 6:53 pm I have replaced the parameter set listing with the old server-side script. That is a bit less functional but it works. Please check it out.

https://openinverter.org/parameters/
Thanks, at least this version is browsable. Sorry I didn't have time to fix it.

Re: Parameter database doesn't browse well

Posted: Wed Aug 02, 2023 1:56 pm
by johu
No worries, didn't take very long

Re: Parameter database doesn't browse well

Posted: Sat Aug 26, 2023 6:52 pm
by Bratitude
upload button is gone :(

i think it would be great if some of the prams where updated, i wanted to push my leaf prams,

maybe johu you can push yours up? the gt86 ones are a bit dated