openinverter forum

evMacGyver wrote: ↑Mon Jan 24, 2022 6:29 pm Really nice, thank you for sharing! Exactly what I was looking for, new web interface and I like splitting code to separate files. Tested shortly with my spare gearbox "on the table", will test more later.

xp677 wrote: ↑Mon Jan 24, 2022 10:30 pm if((mg1_speed>MAX_SPEED)||(-mg1_speed>MAX_SPEED)) torque=0;

charlie@charlie-ThinkPad-T14:~$ cat negative.c
#include "stdint.h"
#include "stdio.h"

int16_t mg1_speed = 10;
int main() {
  printf("%i\n", mg1_speed);
  printf("%i\n", -mg1_speed);
  printf("%i\n", -mg1_speed < -9);
  printf("%i\n", -mg1_speed < -11);
}
charlie@charlie-ThinkPad-T14:~$ gcc negative.c -o negative
charlie@charlie-ThinkPad-T14:~$ ./negative
10
-10
1
0

xp677 wrote: ↑Mon Jan 24, 2022 10:30 pm Line 186 is telling the inverter its max charge / discharge rates, essentially a power limit. Since nobody has ever changed this, this could just go into htm_data[] array to save cycle times.

xp677 wrote: ↑Mon Jan 24, 2022 10:43 pm Sorry just to add, I've edited my post above many more times recently.

xp677 wrote: ↑Mon Jan 24, 2022 10:47 pm Might be wise to clear mth_data on line 263

for (int i = 0; i < 100; i++)mth_data = 0;

At the very least I'd clear mth_data[1] (cycle times and all that) such that a valid packet in a run state can set it back to 1.

xp677 wrote: ↑Mon Jan 24, 2022 10:49 pm These are just my suggestions, it's been almost 3 years since I started with this code, I've forgotten a lot and likely you're more experienced with it than I am.

catphish wrote: ↑Mon Jan 24, 2022 11:00 pm On like 263, a full 100 bytes of mth_data are *always* read from the port and overwritten in the array, so there's no reason to zero it. The monitor_inverter function exits early if there isn't 100 bytes of data available. No processing is done unless 100 bytes is received and the checksum is good.

evMacGyver wrote: ↑Sun Jun 26, 2022 6:07 am Does web module ask every parameter separately using get_config?

  // Poll the motor at regular intervals to request status frames
  poll_inverter();

  // Wait for a status frame from the inverter
  if (monitor_inverter()) {
    // Every time we receive a status frame, calculate torque demand, and send a control frame.
    calculate_torque();
    choose_ratio(); // Note the ratio switching code may override calculated torque
    control_inverter();
  }

evMacGyver wrote: ↑Sun Jun 26, 2022 6:07 am I might added too much regen_limit and regen_factor as it made similar aggressive things and could not use it, but that is something to investigate later.

catphish wrote: ↑Sun Jun 26, 2022 8:23 am It's definitely plausible that the inverter times out while this chunk of data is being sent (due to the low speed of serial comms), I'm not sure what the timeout is. The 2ms timing isn't critical, but it will time out after a while if there hasn't been a cycle of poll_inverter, monitor_inverter, control_inverter.

evMacGyver wrote: ↑Wed Jun 29, 2022 5:14 pm I think I need to replace Metro timer to interrupt base for critical stuff

catphish wrote: ↑Wed Jun 29, 2022 8:14 pm

evMacGyver wrote: ↑Wed Jun 29, 2022 5:14 pm I think I need to replace Metro timer to interrupt base for critical stuff

Moving the control code to an interrupt makes sense too

evMacGyver wrote: ↑Sat Jul 09, 2022 3:09 pm To get inverter control interrupt based, REQ is toggled every 2 ms, so that will make 4 ms signal of 250Hz? And as we are waiting for 100 bytes of return data, it should happen every 100 bytes*4 ms. After receiving 100 bytes we will send back 80 bytes of data. Is this even nearly correct?

evMacGyver wrote: ↑Mon Sep 19, 2022 12:45 pm Does anybody have idea why web interface graph only shows maximum on 8 bit value? If eg. I select mg speed and start accelerating, graph will rise to 255rpm and start again from 0rpm, showing saw tooth. Just wondering if its VCU or wifi module code?

For interrupt base code, I did try it on summer and it was quite simple mod after all. But I got very weird behavior in vehicle side, so I did leave investigation of that later, summer is too short.

catphish wrote: ↑Mon Sep 19, 2022 2:50 pm Thanks for testing! Just had a look, this is quite an obvious / silly bug. The function to fetch a value for the web interface would only ever return an 8 bit value. Not sure how I missed that in my own testing!